From 741a35dee8b9468a01251addd08275f41cd8af6f Mon Sep 17 00:00:00 2001
From: mrjvs <jellevs@gmail.com>
Date: Sat, 20 Jan 2024 13:20:06 +0100
Subject: [PATCH] Style and localize the preference section of settings

---
 src/assets/locales/en.json                   |  7 ++-
 src/components/buttons/Toggle.tsx            |  2 +-
 src/pages/parts/settings/PreferencesPart.tsx | 50 +++++++++++++-------
 src/pages/parts/settings/SidebarPart.tsx     |  2 +-
 4 files changed, 41 insertions(+), 20 deletions(-)

diff --git a/src/assets/locales/en.json b/src/assets/locales/en.json
index 77ac5aab..845d2756 100644
--- a/src/assets/locales/en.json
+++ b/src/assets/locales/en.json
@@ -408,10 +408,13 @@
         "urlPlaceholder": "https://"
       }
     },
-    "locale": {
+    "preferences": {
       "language": "Application language",
       "languageDescription": "Language applied to the entire application.",
-      "title": "Locale"
+      "title": "Preferences",
+      "thumbnail": "Generate thumbnails",
+      "thumbnailDescription": "Most of the time, videos don't have thumbnails. You can enable this setting to generate them on the fly but they can make your video slower.",
+      "thumbnailLabel": "Generate thumbnails"
     },
     "reset": "Reset",
     "save": "Save",
diff --git a/src/components/buttons/Toggle.tsx b/src/components/buttons/Toggle.tsx
index 3fcb0071..8cedc245 100644
--- a/src/components/buttons/Toggle.tsx
+++ b/src/components/buttons/Toggle.tsx
@@ -1,6 +1,6 @@
 import classNames from "classnames";
 
-export function Toggle(props: { onClick: () => void; enabled?: boolean }) {
+export function Toggle(props: { onClick?: () => void; enabled?: boolean }) {
   return (
     <button
       type="button"
diff --git a/src/pages/parts/settings/PreferencesPart.tsx b/src/pages/parts/settings/PreferencesPart.tsx
index ea06db6f..2c1c5f37 100644
--- a/src/pages/parts/settings/PreferencesPart.tsx
+++ b/src/pages/parts/settings/PreferencesPart.tsx
@@ -1,5 +1,6 @@
 import { useTranslation } from "react-i18next";
 
+import { Toggle } from "@/components/buttons/Toggle";
 import { FlagIcon } from "@/components/FlagIcon";
 import { Dropdown } from "@/components/form/Dropdown";
 import { Heading1 } from "@/components/utils/Text";
@@ -28,22 +29,39 @@ export function PreferencesPart(props: {
   );
 
   return (
-    <div>
-      <Heading1 border>{t("settings.locale.title")}</Heading1>
-      <p className="text-white font-bold mb-3">
-        {t("settings.locale.language")}
-      </p>
-      <p className="max-w-[20rem] font-medium">
-        {t("settings.locale.languageDescription")}
-      </p>
-      <Dropdown
-        options={options}
-        selectedItem={selected || options[0]}
-        setSelectedItem={(opt) => props.setLanguage(opt.id)}
-      />
-      <p onClick={() => props.setEnableThumbnails(!props.enableThumbnails)}>
-        thumbnails: {props.enableThumbnails.toString()}
-      </p>
+    <div className="space-y-12">
+      <Heading1 border>{t("settings.preferences.title")}</Heading1>
+      <div>
+        <p className="text-white font-bold mb-3">
+          {t("settings.preferences.language")}
+        </p>
+        <p className="max-w-[20rem] font-medium">
+          {t("settings.preferences.languageDescription")}
+        </p>
+        <Dropdown
+          options={options}
+          selectedItem={selected || options[0]}
+          setSelectedItem={(opt) => props.setLanguage(opt.id)}
+        />
+      </div>
+
+      <div>
+        <p className="text-white font-bold mb-3">
+          {t("settings.preferences.thumbnail")}
+        </p>
+        <p className="max-w-[25rem] font-medium">
+          {t("settings.preferences.thumbnailDescription")}
+        </p>
+        <div
+          onClick={() => props.setEnableThumbnails(!props.enableThumbnails)}
+          className="bg-dropdown-background hover:bg-dropdown-hoverBackground select-none my-4 cursor-pointer space-x-3 flex items-center max-w-[25rem] py-3 px-4 rounded-lg"
+        >
+          <Toggle enabled={props.enableThumbnails} />
+          <p className="flex-1 text-white font-bold">
+            {t("settings.preferences.thumbnailLabel")}
+          </p>
+        </div>
+      </div>
     </div>
   );
 }
diff --git a/src/pages/parts/settings/SidebarPart.tsx b/src/pages/parts/settings/SidebarPart.tsx
index 560d9e5a..47469a5e 100644
--- a/src/pages/parts/settings/SidebarPart.tsx
+++ b/src/pages/parts/settings/SidebarPart.tsx
@@ -44,7 +44,7 @@ export function SidebarPart() {
       icon: Icons.USER,
     },
     {
-      textKey: "settings.locale.title",
+      textKey: "settings.preferences.title",
       id: "settings-preferences",
       icon: Icons.SETTINGS,
     },